TEST: fix alltoall onesided buf mt #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfaderhold21
approved these changes
Jul 11, 2023
manjugv
approved these changes
Jul 12, 2023
Sergei-Lebedev
approved these changes
Jul 12, 2023
Sergei-Lebedev
force-pushed
the
gtest_alltoall_onesided_fix
branch
from
e4294d1
to
1b95cbb
Compare
jeniaka
pushed a commit
to jeniaka/ucc
that referenced
this pull request
Aug 14, 2023
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In gtest alltoall onesided test when running with memory type cuda, sbuf and rbuf memory types are set to cuda but in practice use team->procs[i].p->onesided_buf which are allocated as host memory buffers during create_ context().
Why ?
Bug fix
How ?
In this onesided case using onesided buffers from context, set sbuf and rbuf mem type to be host.